Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a header anchor link to every header rendered from commentary #2079

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

badboy
Copy link
Member

@badboy badboy commented Jan 22, 2024

Fixes mozilla/glean-annotations#217

Completely unstyled for now, because I have no idea how to actually apply styling here.
I tried inline <style> but nothing seems to work.
Probably should make the headings black and underlined on hover.

cc @aminomancer

Pull Request checklist

  • The pull request has a descriptive title (and a reference to an issue it
    fixes, if applicable)
  • All tests and linter checks are passing
  • The pull request is free of merge conflicts

@badboy badboy requested a review from Iinh January 22, 2024 12:14
src/components/Markdown.svelte Outdated Show resolved Hide resolved
src/components/Markdown.svelte Show resolved Hide resolved
Copy link
Contributor

@Iinh Iinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this! r+ pending tests passing.

@badboy badboy force-pushed the annotations-header-anchor-links branch 2 times, most recently from b8240cf to 88826c0 Compare February 12, 2024 10:54
@badboy badboy force-pushed the annotations-header-anchor-links branch from 88826c0 to 65edc2d Compare February 12, 2024 11:08
@badboy badboy merged commit 0802a3f into mozilla:main Feb 26, 2024
7 checks passed
@badboy badboy deleted the annotations-header-anchor-links branch February 26, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headings as anchor links?
3 participants