Bug 1785127 - Upgrade ts-node package to 10.8.0 to fix ESM issues #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosahbruno
changed the title
rosahbruno
force-pushed
the
1785127-newer-node-version-issues
branch
from
403a83c
to
c22b40d
Compare
The maintainers of the `ts-node` package added this fix to their repo in version 10.8.0 to deal with the short-circuit ESM errors. TypeStrong/ts-node#1715
rosahbruno
force-pushed
the
1785127-newer-node-version-issues
branch
from
c22b40d
to
3969bc1
Compare
travis79
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maintainers of the
ts-nodepackage added this fix to their repo in version 10.8.0 to deal with the short-circuit ESM errors. I was able to run all tests from thegleandirectory as well as confirm that all the samples projects are still working as expected.TypeStrong/ts-node#1715
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lintRuns all lintersCHANGELOG.mdor an explanation of why it does not need oneDocumentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that workDocumentation should be added to The Glean Book when making changes to Glean's user facing APIWhen changes to the Glean Book are necessary, link to the corresponding PR on themozilla/gleanrepositoryDocumentation should be added to the Glean.js developer documentation when making internal code changes