Attend to review comments

* Fix RFC link in `validate_base64url_encoding`; * Validate each field in JWE separately and specifically; * Fix comment for `set` function; * Add tests for get_test_value_* functions; * Apply lints from new Rust version.
mozilla · Jul 17, 2020 · afd1408 · afd1408
1 parent 56c094b
commit afd1408
Show file tree

Hide file tree

Showing 3 changed files with 266 additions and 129 deletions.
diff --git a/glean-core/ffi/src/jwe.rs b/glean-core/ffi/src/jwe.rs
@@ -60,15 +60,10 @@ pub extern "C" fn glean_jwe_test_has_value(metric_id: u64, storage_name: FfiStr)
 }
 
 #[no_mangle]
-pub extern "C" fn glean_jwe_test_get_value(
-    metric_id: u64,
-    storage_name: FfiStr,
-) -> *mut c_char {
+pub extern "C" fn glean_jwe_test_get_value(metric_id: u64, storage_name: FfiStr) -> *mut c_char {
     with_glean_value(|glean| {
         JWE_METRICS.call_infallible(metric_id, |metric| {
-            metric
-                .test_get_value(glean, storage_name.as_str())
-                .unwrap()
+            metric.test_get_value(glean, storage_name.as_str()).unwrap()
         })
     })
 }