Bug 1609968 - Remove locale from baseline ping #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
requested review from
Dexterp37 and
mdboom
and removed request for
Dexterp37
brizental
commented
Jun 25, 2020
Dexterp37
reviewed
Jun 25, 2020
Yeah, was not sure about the UPDATE: opened a bug for the glean_parser problem, will fix that and then we can merge this after. |
3 tasks
brizental
force-pushed
the
1609968-remove-locale-baseline
branch
from
8061940
to
4e93618
Compare
Dexterp37
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Bug 1609968
Opening this as a draft because I believe the
send_if_emptyaddition to the baseline ping should be discussed.Removing the locale means that when
foregroundordirty_startupthe baseline ping will have no metrics, so I believe adding this flag makes sense. If everyone agrees on that, still this would need to wait for a fix in the glean_parser, because thesend_if_emptybreaks the baseline ping documentation.