Bug 1634064 - Propagate GleanDebugActivity intent options to the main intent
#1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboom
approved these changes
Jul 17, 2020
Products might want to debug a product and launch it using different options. Without this change, such options are discarded by Glean.
Dexterp37
force-pushed
the
debug_activity_options
branch
from
4591907
to
13442b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Products might want to debug a product and launch it using different options. Without this change, such options are discarded by Glean.
How to test this
adb shell am set-debug-app -w org.mozilla.samples.gleancoreintent.data(should be"https://www.example.com") andintent.getStringExtra(otherOption)(should beother-value)More context on why this is needed can be read on the bug.