Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1650787 - Implement JWE metric in the bindings #1073

Merged
merged 11 commits into from
Jul 21, 2020
Merged

Bug 1650787 - Implement JWE metric in the bindings #1073

merged 11 commits into from
Jul 21, 2020

Commits on Jul 20, 2020

  1. Implement JWE metric type for Kotlin

    @brizental
    brizental committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    b2c5396 View commit details
    Browse the repository at this point in the history

  2. Implement JWE metric type for Swift

    @brizental
    brizental committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    4273672 View commit details
    Browse the repository at this point in the history

  3. Implement JWE metric type for C#

    @brizental
    brizental committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    e618d9e View commit details
    Browse the repository at this point in the history

  4. Implement JWE metric type for Python

    @brizental
    brizental committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    040f7b1 View commit details
    Browse the repository at this point in the history

  5. Attend to review comments 

    * setWithCompactRepr -> setWithCompactRepresentation
* testGetValueAsPeriodDelimitedString -> testGetCompactRepresentation
    @brizental
    brizental committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    27dccb5 View commit details
    Browse the repository at this point in the history

  6. Fix lints

    @brizental
    brizental committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    446ac0b View commit details
    Browse the repository at this point in the history

  7. Fix project.pbxproj path

    @brizental
    brizental committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    a42add4 View commit details
    Browse the repository at this point in the history

  8. Actually fix project.pbxproj path

    @brizental
    brizental committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    951c770 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Attend to review comments 

    * Return `JweData` struct from test_get_value (all bindings);
* Add explicit test for `test_get_value` for each binding;
* Fix docstring for python get_test_* functions.
    @brizental
    brizental committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    0d3c08d View commit details
    Browse the repository at this point in the history

  2. Fix swift formatting

    @brizental
    brizental committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    2bde49e View commit details
    Browse the repository at this point in the history

  3. Attend to Swift review comments

    @brizental
    brizental committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    e45fca0 View commit details
    Browse the repository at this point in the history