Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1657292 - Ping registration off main thread #1132

Merged
merged 7 commits into from
Aug 26, 2020
Merged

Bug 1657292 - Ping registration off main thread #1132

merged 7 commits into from
Aug 26, 2020

Commits on Aug 25, 2020

  1. Android: Register pings off the main thread

    @badboy
    badboy committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    c2b0aa2 View commit details
    Browse the repository at this point in the history

  2. Use an atomic boolean to track that initialize was called and returned

    @badboy
    badboy committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    0eec818 View commit details
    Browse the repository at this point in the history

  3. iOS: Register pings off the main thread

    @badboy
    badboy committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    072ea94 View commit details
    Browse the repository at this point in the history

  4. Register builtin pings manually

    @badboy
    badboy committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    ffcadbb View commit details
    Browse the repository at this point in the history

  5. Android: remove test trying to force race-condition in ping registration 

    Now that ping registration happens through the dispatcher this test
overflow the pre-init queue, causing test failures in subsequent tests
due to recorded errors.
    @badboy
    badboy committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    9ba94c2 View commit details
    Browse the repository at this point in the history

  6. Test early registration of custom pings with events

    @badboy
    badboy committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    9f4a28c View commit details
    Browse the repository at this point in the history

  7. Add changelog entry 

    [doc only]
    @badboy
    badboy committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    c4eba55 View commit details
    Browse the repository at this point in the history