-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1685401 - Implement before_next_submit
API
#1507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
force-pushed
the
before-next-submit
branch
2 times, most recently
from
February 22, 2021 16:27
73878bb
to
01ad24d
Compare
badboy
changed the title
Bug 1685401 - RLB: Implement
Bug 1685401 - Implement Feb 22, 2021
before_next_submit
APIbefore_next_submit
API
badboy
force-pushed
the
before-next-submit
branch
2 times, most recently
from
February 22, 2021 16:58
8ffe200
to
d860089
Compare
chutten
requested changes
Feb 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and comments, but I'm really liking how it looks.
badboy
force-pushed
the
before-next-submit
branch
from
February 24, 2021 11:34
d860089
to
43c9691
Compare
chutten
approved these changes
Feb 24, 2021
I'm starting to think the Python failures are legit and I need to look into them. |
badboy
force-pushed
the
before-next-submit
branch
from
February 25, 2021 13:16
43c9691
to
87523c5
Compare
badboy
force-pushed
the
before-next-submit
branch
from
February 25, 2021 13:52
87523c5
to
3ef4243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.