Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1685401 - Implement before_next_submit API #1507

Merged
merged 5 commits into from
Feb 25, 2021
Merged

Conversation

badboy
Copy link
Member

@badboy badboy commented Feb 18, 2021

No description provided.

@badboy badboy force-pushed the before-next-submit branch 2 times, most recently from 73878bb to 01ad24d Compare February 22, 2021 16:27
@badboy badboy marked this pull request as ready for review February 22, 2021 16:28
@auto-assign auto-assign bot requested a review from Dexterp37 February 22, 2021 16:28
@badboy badboy requested a review from chutten February 22, 2021 16:28
@badboy badboy changed the title Bug 1685401 - RLB: Implement before_next_submit API Bug 1685401 - Implement before_next_submit API Feb 22, 2021
@Dexterp37 Dexterp37 removed their request for review February 22, 2021 16:29
@badboy badboy force-pushed the before-next-submit branch 2 times, most recently from 8ffe200 to d860089 Compare February 22, 2021 16:58
Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and comments, but I'm really liking how it looks.

CHANGELOG.md Outdated Show resolved Hide resolved
glean-core/ios/Glean/Metrics/Ping.swift Show resolved Hide resolved
glean-core/rlb/src/private/ping.rs Outdated Show resolved Hide resolved
glean-core/rlb/src/private/ping.rs Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@badboy
Copy link
Member Author

badboy commented Feb 25, 2021

I'm starting to think the Python failures are legit and I need to look into them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants