Bug 1866559 - Support "no-info"-configured pings #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chutten
force-pushed
the
bug1866559-noinfoPings
branch
4 times, most recently
from
4ecb0f6 to
dd84dad
Compare
And update some tests to check it out.
chutten
force-pushed
the
bug1866559-noinfoPings
branch
from
dd84dad to
61f3b81
Compare
travis79
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for OHTTP support. Brings in glean_parser v13 to support it.
Only Rust's uploader does anything with this information. I suppose we could log/throw/record data if a noinfo ping makes it into an unsupported LB's uploader, but I figured just sending it normally might be the more kind approach.
Lotta changed files in this one, I'm afraid. If you'd like to follow the code changes chronologically by how the data flows, the individual commits are arranged in that manner (though Github's review UI is shite at handling that, so my condolences).