Bug 1902992 - Flush database time-based when delayPingLifetimeIo=true #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
force-pushed
the
1902992/flush-time-based
branch
from
7e12e17 to
3e02a45
Compare
|
currently based on #2877, so will be rebased when that lands. |
badboy
force-pushed
the
1902992/flush-time-based
branch
from
3e02a45 to
61f33af
Compare
badboy
commented
Jun 26, 2024
badboy
force-pushed
the
1902992/flush-time-based
branch
from
61f33af to
3b9a08d
Compare
badboy
force-pushed
the
1902992/flush-time-based
branch
from
3b9a08d to
2effc66
Compare
chutten
approved these changes
Jun 28, 2024
|
I ended up adding it as a top-level configuration in this branch: https://github.com/mozilla/glean/compare/1902992/flush-time-based-with-config?expand=1 It still has some TODOs, mostly docs, but I think that's a viable approach. But I won't get that done this week. Edit 2024-07-31: Now done in this PR. |
This allows us to enable that feature in testing or potentially even for other platforms.
badboy
force-pushed
the
1902992/flush-time-based
branch
3 times, most recently
from
d9ca572 to
5edc4b0
Compare
badboy
force-pushed
the
1902992/flush-time-based
branch
from
5edc4b0 to
0c4055c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2871 +/- ##
=======================================
Coverage 31.81% 31.81%
=======================================
Files 1 1
Lines 44 44
=======================================
Hits 14 14
Misses 30 30 ☔ View full report in Codecov by Sentry. |
travis79
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.