Upgrade to UniFFI 0.28 #2920
Merged
Upgrade to UniFFI 0.28 #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
force-pushed
the
upgrade-uniffi-0.28
branch
from
524fe1f
to
e6758ea
Compare
This updates some other dependencies. To avoid a dependency on clap (and all of its dependencies) we bring along our own uniffi-bindgen that implements only the mininmal part. We did that before as well, but now that part is slightly bigger.
badboy
force-pushed
the
upgrade-uniffi-0.28
branch
from
825a3ff
to
2880d26
Compare
travis79
approved these changes
Aug 7, 2024
|
Do we have documentation of the uniffi_bindgen stuff in our developer docs? |
no. what kind of docs do you expect? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates some other dependencies.
To avoid a dependency on clap (and all of its dependencies) we bring along our own uniffi-bindgen that implements only the mininmal part. We did that before as well, but now that part is slightly bigger.
Note: Ben asked me to get that into a Glean release soon. I want another Glean release before this lands though.