Allow timespans to track across upload toggles #2998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
requested review from
rosahbruno and
travis79
and removed request for
a team and
rosahbruno
travis79
approved these changes
Nov 12, 2024
badboy
force-pushed
the
timespan/track-across-upload-toggle
branch
from
29dd7e1
to
d115ec4
Compare
This is a pre-requisite to allow the coming per-ping toggle: At the `start` time we don't know _which_ pings to record for. It's fine to do this because: * Timespans, if at all, usually collect a span over a single action, with no chance of a upload toggle happening in between * There's very few timespans in use right now * It's often the wrong metric type anyway, and timing distributions should be used * Timing Distributions already allow this
badboy
force-pushed
the
timespan/track-across-upload-toggle
branch
from
d115ec4
to
87a0e2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-requisite to allow the coming per-ping toggle:
At the
starttime we don't know which pings to record for.It's fine to do this because: