Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop sorting entries for GlobSet #225

Closed
marco-c opened this issue Oct 30, 2018 · 1 comment · Fixed by #271
Closed

Stop sorting entries for GlobSet #225

marco-c opened this issue Oct 30, 2018 · 1 comment · Fixed by #271
Assignees
@marco-c

Comments

@marco-c
Copy link
Collaborator

marco-c commented Oct 30, 2018

When BurntSushi/ripgrep#1079 is fixed, we can stop doing:

grcov/src/path_rewriting.rs

Line 183 in 131f66f

// workaround for bug: https://github.com/BurntSushi/ripgrep/issues/1079

@marco-c
Copy link
Collaborator Author

marco-c commented Feb 17, 2019

We can now do this, as BurntSushi/ripgrep#1079 was fixed.

marco-c added a commit that referenced this issue Mar 29, 2019
@marco-c
Remove no longer needed workaround of sorting glob sets
fb16865 
Fixes #225
@marco-c marco-c mentioned this issue Mar 29, 2019
Merged
@marco-c marco-c self-assigned this Mar 29, 2019
marco-c added a commit that referenced this issue Apr 20, 2019
@marco-c
Remove no longer needed workaround of sorting glob sets
c5d8aec 
Fixes #225
marco-c added a commit that referenced this issue Apr 20, 2019
@marco-c
Remove no longer needed workaround of sorting glob sets (#271)
5db5160 
Fixes #225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marco-c marco-c

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove no longer needed workaround of sorting glob sets mozilla/grcov
1 participant
@marco-c