[bug 926611] Fix y axis re-scaling on aggregated charts. #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -233,6 +233,7 @@ function makeAggregatedWikiMetricGraphs() { | |||
| graph.data.seriesSpec[index].disabled = true; | |||
| } | |||
| }); | |||
| graph.rebucket(); | |||
There was a problem hiding this comment.
My flakey memory tells me that I left this out for performance reasons last time. Does this have a negative affect on the KPI graphs? If nothing else, you should probably remove calls to .rebucket() anywhere else that .update() is called (like in the slider.)
There was a problem hiding this comment.
This only affects the one page. And yeah, it is pretty slow to update when you check/uncheck locales... but whatevs.
There was a problem hiding this comment.
Oh, oops. I thought this was in rickshaw_utils.js.
|
If this works, it looks good to me! r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r?