Final review fixes

client/src/index.js

@@ -230,8 +230,11 @@ function createFS(options) {
 
   // Request that a sync begin.
   sync.request = function() {
-    // We do not expose a prototype that allows
-    // the path to be specified
+    // sync.request does not take any parameters
+    // as the path to sync is determined internally
+    // requestSync on the other hand optionally takes
+    // a path to sync which can be specified for
+    // internal use
     requestSync();
   };
 

client/src/message-handler.js

@@ -131,7 +131,7 @@ function handleResponse(syncManager, data) {
     session.step = steps.SYNCED;
 
     function stampChecksum(path, callback) {
-      fs.stat(path, function(err, stats) {
+      fs.lstat(path, function(err, stats) {
         if(err) {
           if(err.code !== 'ENOENT') {
             return callback(err);

lib/rsync/diff.js

@@ -28,12 +28,12 @@ module.exports = function diff(fs, path, checksumList, options, callback) {
   // Compute the checksum for the file/link and
   // append it to the diffNode.
   function appendChecksum(diffNode, diffPath, callback) {
-    rsyncUtils.getChecksum(fs, diffPath, function(err, checksums) {
+    rsyncUtils.getChecksum(fs, diffPath, function(err, checksum) {
       if(err) {
         return callback(err);
       }
 
-      diffNode.checksum = checksums;
+      diffNode.checksum = checksum;
       diffList.push(diffNode);
 
       callback(null, diffList);

lib/rsync/patch.js

@@ -148,6 +148,8 @@ module.exports = function patch(fs, path, diffList, options, callback) {
   }
 
   function maybeGenerateConflicted(nodePath, callback) {
+    // If the file has not been synced upstream
+    // and needs to be patched, create a conflicted copy
     fsUtils.isPathUnsynced(fs, nodePath, function(err, unsynced) {
       if(err) {
         return handleError(err, callback);
@@ -187,7 +189,7 @@ module.exports = function patch(fs, path, diffList, options, callback) {
     // If they match, the file is not patched and needs to
     // be upstreamed
     function compareVersions(data) {
-      fs.stat(filePath, function(err, stats) {
+      fs.lstat(filePath, function(err, stats) {
         if(err) {
           return handleError(err, callback);
         }
@@ -206,6 +208,8 @@ module.exports = function patch(fs, path, diffList, options, callback) {
 
           // If the last synced checksum matches the
           // diffNode's checksum, ignore the patch
+          // because it is a newer version than whats on
+          // the server
           if(checksum === diffNode.checksum) {
             paths.needsUpstream.push(filePath);
             return callback(null, paths);