Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert mozjexl output to an mjs module #33

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Standard8
Copy link
Member

This converts to use Rollup for generating the module. From what I can tell, it isn't currently easy to get Webpack to generate a library that's an ES module.

I've also done a general node_modules update as well whilst I'm here.

The new file isn't minified, though we can change that if we want to.

@dmose
Copy link
Member

dmose commented Aug 4, 2023

Thanks for this patch, and sorry for the long delay in getting to it! At a high level, this is great. There are a couple of things I'm concerned about:

  1. I'd prefer not doing the eslint stuff and reformatting as part of this (or really at all, unless it moves into m-c), because
    a) I'd like to make it easier to pull changes in from upstream; there are multiple we might want.
    b) I don't want to bit-rot Add an option to throw errors for non-existant properties  #25, though I don't know when someone will get back to that.

  2. The switch to parcel adds some risk: https://phabricator.services.mozilla.com/D178187#6130439 has more details. I tried playing around with the webpack 3 in use here, and it wasn't obvious how to make it do the right thing, but I didn't spend a lot time on it. Upgrading to webpack 5 is possible, though I suspect it's similarly risky to switching to parcel, and then leaves us using something (webpack) with many more dependencies and harder-to-debug code.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants