Bug 1914478: Replace usage of stdlib pipes library with shlex #1846
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.13 removed the already deprecated "pipes" module from the standard library. Some files were using the "quote" function from pipes, which prior to 3.13 was a re-export of a function with the same name in "shlex". This change imports the shlex module directly. https://github.com/python/cpython/blob/3.12/Lib/pipes.py#L66 https://docs.python.org/3/whatsnew/3.13.html
|
I don't have review access here, but if I did I would approve this. I had similar fixes in m-c at https://bugzilla.mozilla.org/show_bug.cgi?id=1926140 When this PR is merged and a new release is made, https://bugzilla.mozilla.org/show_bug.cgi?id=1914478 can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.13 removed the already deprecated "pipes" module from the standard library.
Some files were using the "quote" function from pipes, which prior to 3.13 was a re-export of a function with the same name in "shlex".
This change imports the shlex module directly.
https://github.com/python/cpython/blob/3.12/Lib/pipes.py#L66 https://docs.python.org/3/whatsnew/3.13.html