Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clippy to build action. #282

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Add clippy to build action. #282

merged 2 commits into from
Mar 15, 2021

Conversation

kinetiknz
Copy link
Collaborator

Inspired by #186, updated for GitHub Actions.

Running a separate step for nightly clippy is annoying, but non-nightly builds don't recognize clippy::upper_case_acronyms and as far as I understand it's not currently possible to disable lints via Cargo.toml or clippy.toml.

@kinetiknz kinetiknz self-assigned this Mar 12, 2021
Copy link
Contributor

@baumanj baumanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but I'd like to understand the rationale around the To -> Into naming change before signing off.

mp4parse/src/lib.rs Outdated Show resolved Hide resolved
mp4parse/src/lib.rs Outdated Show resolved Hide resolved
mp4parse_capi/src/lib.rs Show resolved Hide resolved
@kinetiknz
Copy link
Collaborator Author

I removed the nightly-only clippy CI step in favour of handling lint allow lines in the code itself - this has the advantage of in the generating the same results locally for a simple cargo clippy without having to copy the project-specific settings out of the CI config.

Copy link
Contributor

@baumanj baumanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we just add these comments referencing the appropriate clippy issue?

mp4parse/src/lib.rs Show resolved Hide resolved
mp4parse/src/lib.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants