Implement RACK variation for QUIC #1486
Draft
+113
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highly WIP: Early Draft, already working, but not necessary final version. Not necessary to read through yet, only if you are interested. Submitting already, because I probably only continue next week.
This is a modified version of RACK for QUIC. The high level is working, but the algorithm differs a bit from the RFC due to more information available in QUIC than TCP.
What it does:
reo_wnd_mult
to high enough to not detect the same amount of packet reordering as packet loss next timeCongestionAvoidance
reducereo_wnd_persist
by one. and setreo_wnd_mult
to the next non-zero entry ofreo_wnd_mult
.I am still considering to make the implementation "dumper" and maybe simpler/more readable by following the RFC more closely.
reo_wnd_mult += 1
should only be called once per RTT -> need state for thatStill TODO:
bool
fromon_packets_acked
is fineprintln
for print statements that should stay