Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feature flag Datagram::into_data #1695

Merged
merged 4 commits into from
Mar 5, 2024

Commits on Feb 29, 2024

  1. feat(.github): run cargo clippy on each crate individually

    > Use cargo-hack to run clippy on each crate individually with its
    > respective default features only. Can reveal warnings otherwise
    > hidden given that a plain cargo clippy combines all features of the
    > workspace. See e.g. mozilla#1695.
    mxinden committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    cde3814 View commit details
    Browse the repository at this point in the history
  2. fix: feature flag Datagram::into_data

    `Datagram::into_data` is used in `neqo_common::udp` only. `neqo_common::udp` is
    behind the `udp` feature. The feature is not part of the crate's default
    features. Thus a plain `cargo check` rightly complains with:
    
    ```
    warning: method `into_data` is never used
      --> neqo-common/src/datagram.rs:58:19
       |
    20 | impl Datagram {
       | ------------- method in this implementation
    ...
    58 |     pub(crate) fn into_data(self) -> Vec<u8> {
       |                   ^^^^^^^^^
       |
       = note: `#[warn(dead_code)]` on by default
    ```
    
    This commit hides `into_data` behind the `udp` feature as well.
    mxinden committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    89814fb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d9ed682 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Configuration menu
    Copy the full SHA
    2c3de82 View commit details
    Browse the repository at this point in the history