Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(bin/server): increase msg size and don't allocate msg per resp #1772

Merged
merged 2 commits into from
Mar 27, 2024
Merged

perf(bin/server): increase msg size and don't allocate msg per resp #1772

merged 2 commits into from
Mar 27, 2024

Commits on Mar 25, 2024

  1. perf(bin/server): increase msg size and don't allocate msg per resp 

    Previously `neqo-server` would respond to a request by repeatedly sending a
static 440 byte message (Major-General's Song). Instead of sending 440 bytes,
increase the batch size to 4096 bytes. This also matches the `neqo-client`
receive buffer size.

https://github.com/mozilla/neqo/blob/76630a5ebb6c6b94de6a40cf3f439b9a846f6ab7/neqo-bin/src/bin/client/http3.rs#L165

Previously `ResponseData::repeat` would convert the provided `buf: &[u8]` to `
Vec<u8>`, i.e. re-allocate the buf. Instead keep a reference to the original
buf, thus removing the allocation.
    @mxinden
    mxinden committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    772604e View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Remove unnecessary into()

    @mxinden
    mxinden committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3d60e25 View commit details
    Browse the repository at this point in the history