fix: Rework QNS tables

[larseggert]

Fixes #1845

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (3797225) to head (6be647f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1846      +/-   ##
==========================================
- Coverage   93.23%   93.23%   -0.01%     
==========================================
  Files         110      110              
  Lines       35749    35749              
==========================================
- Hits        33330    33329       -1     
- Misses       2419     2420       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark results

Performance differences relative to 3797225.

• drain a timer quickly time: [428.74 ns 435.09 ns 441.15 ns]
  change: [-1.2766% +0.0163% +1.2595%] (p = 0.98 > 0.05)
  No change in performance detected.

• coalesce_acked_from_zero 1+1 entries
  time: [197.94 ns 198.46 ns 199.02 ns]
  change: [-0.3940% +0.0627% +0.5569%] (p = 0.82 > 0.05)
  No change in performance detected.

• coalesce_acked_from_zero 3+1 entries
  time: [238.18 ns 238.89 ns 239.63 ns]
  change: [-0.7687% -0.3272% +0.1162%] (p = 0.15 > 0.05)
  No change in performance detected.

• coalesce_acked_from_zero 10+1 entries
  time: [237.66 ns 238.76 ns 239.97 ns]
  change: [-2.6398% -0.6018% +0.6361%] (p = 0.66 > 0.05)
  No change in performance detected.

• coalesce_acked_from_zero 1000+1 entries
  time: [218.61 ns 218.83 ns 219.09 ns]
  change: [-0.5250% +0.2787% +1.1944%] (p = 0.53 > 0.05)
  No change in performance detected.

• RxStreamOrderer::inbound_frame()
  time: [118.38 ms 118.56 ms 118.81 ms]
  change: [-0.4858% -0.3201% -0.0906%] (p = 0.00 < 0.05)
  Change within noise threshold.

• transfer/Run multiple transfers with varying seeds
  time: [121.83 ms 122.09 ms 122.34 ms]
  thrpt: [32.695 MiB/s 32.764 MiB/s 32.834 MiB/s]
  change:
  time: [-2.3789% -2.0855% -1.7946%] (p = 0.00 < 0.05)
  thrpt: [+1.8274% +2.1299% +2.4369%]
  Change within noise threshold.

• transfer/Run multiple transfers with the same seed
  time: [122.31 ms 122.51 ms 122.72 ms]
  thrpt: [32.596 MiB/s 32.651 MiB/s 32.704 MiB/s]
  change:
  time: [-2.1058% -1.8510% -1.6112%] (p = 0.00 < 0.05)
  thrpt: [+1.6376% +1.8860% +2.1511%]
  Change within noise threshold.

• 1-conn/1-100mb-resp (aka. Download)/client
  time: [1.1089 s 1.1158 s 1.1221 s]
  thrpt: [89.119 MiB/s 89.625 MiB/s 90.179 MiB/s]
  change:
  time: [-1.1779% -0.3663% +0.3727%] (p = 0.41 > 0.05)
  thrpt: [-0.3713% +0.3676% +1.1919%]
  No change in performance detected.

• 1-conn/10_000-parallel-1b-resp (aka. RPS)/client
  time: [423.80 ms 425.73 ms 427.70 ms]
  thrpt: [23.381 Kelem/s 23.489 Kelem/s 23.596 Kelem/s]
  change:
  time: [-2.3047% -1.5978% -0.8748%] (p = 0.00 < 0.05)
  thrpt: [+0.8825% +1.6238% +2.3591%]
  Change within noise threshold.

• 1-conn/1-1b-resp (aka. HPS)/client
  time: [50.548 ms 50.869 ms 51.218 ms]
  thrpt: [19.525 elem/s 19.658 elem/s 19.783 elem/s]
  change:
  time: [-0.9066% +0.0463% +1.0397%] (p = 0.92 > 0.05)
  thrpt: [-1.0290% -0.0463% +0.9149%]
  No change in performance detected.

Client/server transfer results

Transfer of 134217728 bytes over loopback.

Client	Server	CC	Pacing	Mean [ms]	Min [ms]	Max [ms]	Relative
msquic	msquic			665.7 ± 346.1	343.7	1305.5	1.00
neqo	msquic	reno	on	964.2 ± 229.3	771.8	1457.6	1.00
neqo	msquic	reno		1079.1 ± 311.8	779.4	1544.8	1.00
neqo	msquic	cubic	on	999.3 ± 239.5	799.9	1418.7	1.00
neqo	msquic	cubic		1096.5 ± 314.9	783.4	1484.0	1.00
msquic	neqo	reno	on	4462.0 ± 240.2	4173.9	5013.4	1.00
msquic	neqo	reno		4467.0 ± 281.5	4110.0	5125.6	1.00
msquic	neqo	cubic	on	4407.3 ± 168.0	4152.6	4641.7	1.00
msquic	neqo	cubic		4546.2 ± 245.9	4284.5	5072.5	1.00
neqo	neqo	reno	on	3719.3 ± 248.4	3414.1	4249.4	1.00
neqo	neqo	reno		3454.1 ± 213.5	3207.2	3875.9	1.00
neqo	neqo	cubic	on	4369.5 ± 182.2	4089.1	4592.6	1.00
neqo	neqo	cubic		4405.8 ± 211.7	4120.1	4764.0	1.00

⬇️ Download logs