ci: Pin NSS to prevent build hang on Windows #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
larseggert
changed the title
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2106 +/- ##
=======================================
Coverage 95.33% 95.33%
=======================================
Files 112 112
Lines 36287 36300 +13
=======================================
+ Hits 34594 34608 +14
+ Misses 1693 1692 -1 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 0b106c2. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.270 ns 99.569 ns 99.880 ns]
change: [-0.4520% +0.1338% +0.6376%] (p = 0.66 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.20 ns 117.54 ns 117.90 ns]
change: [-0.2499% +0.1380% +0.4788%] (p = 0.48 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.71 ns 116.96 ns 117.32 ns]
change: [-0.4114% +0.0412% +0.4581%] (p = 0.86 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.482 ns 97.593 ns 97.727 ns]
change: [-0.9965% -0.1404% +0.6340%] (p = 0.75 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.70 ms 111.76 ms 111.81 ms]
change: [+0.2700% +0.3405% +0.4083%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [27.238 ms 28.301 ms 29.379 ms]
change: [-4.1352% +0.9372% +6.3279%] (p = 0.73 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [35.006 ms 36.634 ms 38.277 ms]
change: [-4.8503% +1.3002% +7.6053%] (p = 0.69 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [32.160 ms 32.847 ms 33.519 ms]
change: [-2.6082% +0.3149% +3.3946%] (p = 0.84 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [45.345 ms 48.349 ms 51.310 ms]
change: [-3.6832% +6.2947% +16.416%] (p = 0.21 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: 💚 Performance has improved. time: [112.64 ms 113.15 ms 113.63 ms]
thrpt: [880.03 MiB/s 883.75 MiB/s 887.75 MiB/s]
change:
time: [-2.2509% -1.6509% -1.1015%] (p = 0.00 < 0.05)
thrpt: [+1.1138% +1.6786% +2.3027%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [312.80 ms 316.03 ms 319.26 ms]
thrpt: [31.322 Kelem/s 31.642 Kelem/s 31.970 Kelem/s]
change:
time: [-2.3016% -0.7866% +0.7395%] (p = 0.32 > 0.05)
thrpt: [-0.7341% +0.7929% +2.3558%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.719 ms 33.942 ms 34.179 ms]
thrpt: [29.258 elem/s 29.462 elem/s 29.657 elem/s]
change:
time: [-1.5092% -0.5948% +0.3464%] (p = 0.22 > 0.05)
thrpt: [-0.3452% +0.5984% +1.5323%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
jschanck
added a commit
to jschanck/neqo
that referenced
this pull request
Sep 13, 2024
This reverts commit 4aa0319.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MLKEM patches make the NSS build on Windows hang indefinitely. Until we fix that, pin NSS to the last working revision before MLKEM landed.
(Also switch to using
actions/checkoutand hence don't install mercurial anymore.)CC @jschanck