fix: typos #2113
Merged
fix: typos #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
larseggert
approved these changes
Sep 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2113 +/- ##
=======================================
Coverage 95.35% 95.35%
=======================================
Files 112 112
Lines 36319 36319
=======================================
Hits 34631 34631
Misses 1688 1688 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 9dd05bb. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.557 ns 99.806 ns 100.07 ns]
change: [-0.1075% +0.4054% +0.9551%] (p = 0.13 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [118.07 ns 118.88 ns 120.23 ns]
change: [+0.7419% +1.2843% +1.9377%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [117.91 ns 118.49 ns 119.14 ns]
change: [+0.5601% +1.0127% +1.4913%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [98.630 ns 98.789 ns 98.970 ns]
change: [+0.0790% +0.8924% +1.6358%] (p = 0.02 < 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.54 ms 111.60 ms 111.65 ms]
change: [-0.0380% +0.0280% +0.0966%] (p = 0.42 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [27.067 ms 27.976 ms 28.878 ms]
change: [-2.7287% +1.9697% +6.8826%] (p = 0.43 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.857 ms 36.411 ms 37.957 ms]
change: [-6.1763% -0.0918% +6.3730%] (p = 0.97 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [31.375 ms 32.115 ms 32.832 ms]
change: [-3.5153% -0.5041% +2.5042%] (p = 0.74 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [40.074 ms 42.732 ms 45.370 ms]
change: [-6.3152% +2.6192% +12.096%] (p = 0.57 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [112.69 ms 115.91 ms 121.79 ms]
thrpt: [821.08 MiB/s 862.72 MiB/s 887.38 MiB/s]
change:
time: [-2.3955% +0.5344% +7.1360%] (p = 0.84 > 0.05)
thrpt: [-6.6607% -0.5316% +2.4543%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [316.68 ms 320.26 ms 323.89 ms]
thrpt: [30.875 Kelem/s 31.224 Kelem/s 31.578 Kelem/s]
change:
time: [-1.0855% +0.5389% +2.1773%] (p = 0.51 > 0.05)
thrpt: [-2.1309% -0.5360% +1.0974%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [34.130 ms 34.280 ms 34.445 ms]
thrpt: [29.032 elem/s 29.171 elem/s 29.300 elem/s]
change:
time: [-0.5919% +0.0884% +0.7899%] (p = 0.80 > 0.05)
thrpt: [-0.7837% -0.0883% +0.5955%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.