Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use vmactions for checks on other platforms #2133

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

larseggert
Copy link
Collaborator

@larseggert larseggert commented Sep 24, 2024

WIP

This needs to wait until the nss packages for these platforms have caught up with our minimum version requirement, since building NSS on these platforms requires extensive patching.

As of 2024-10-3:

Ditto for their rust packages, since rustup doesn't support most of these.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (d669f0c) to head (5bb3f14).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2133      +/-   ##
==========================================
+ Coverage   95.39%   95.45%   +0.05%     
==========================================
  Files         113      113              
  Lines       36683    36683              
==========================================
+ Hits        34994    35014      +20     
+ Misses       1689     1669      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 24, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to 9143d73.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Copy link

github-actions bot commented Sep 24, 2024

Benchmark results

Performance differences relative to d513712.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.544 ns 99.782 ns 100.01 ns]
       change: [-0.1021% +0.2721% +0.6885%] (p = 0.17 > 0.05)

Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [117.73 ns 118.05 ns 118.39 ns]
       change: [-6.4712% -1.9072% +0.8059%] (p = 0.59 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
2 (2.00%) low mild
1 (1.00%) high mild
10 (10.00%) high severe

coalesce_acked_from_zero 10+1 entries: Change within noise threshold.
       time:   [117.26 ns 117.72 ns 118.28 ns]
       change: [+0.0462% +0.5159% +0.9066%] (p = 0.02 < 0.05)

Found 15 outliers among 100 measurements (15.00%)
6 (6.00%) low severe
1 (1.00%) low mild
2 (2.00%) high mild
6 (6.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [98.654 ns 98.771 ns 98.910 ns]
       change: [-0.2649% +1.4262% +2.8301%] (p = 0.06 > 0.05)

Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) high mild
4 (4.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.32 ms 111.38 ms 111.44 ms]
       change: [+0.1359% +0.2089% +0.2781%] (p = 0.00 < 0.05)

Found 14 outliers among 100 measurements (14.00%)
10 (10.00%) low mild
4 (4.00%) high mild

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.152 ms 27.253 ms 28.370 ms]
       change: [-6.5578% -1.3266% +4.2538%] (p = 0.65 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [34.880 ms 36.607 ms 38.359 ms]
       change: [-8.5961% -1.6625% +5.3725%] (p = 0.64 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-false/same-seed: No change in performance detected.
       time:   [26.069 ms 26.830 ms 27.599 ms]
       change: [-4.4085% -0.1847% +4.1908%] (p = 0.93 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-true/same-seed: No change in performance detected.
       time:   [40.830 ms 43.057 ms 45.367 ms]
       change: [-4.0012% +3.0510% +9.8066%] (p = 0.41 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [112.85 ms 113.30 ms 113.74 ms]
       thrpt:  [879.19 MiB/s 882.58 MiB/s 886.11 MiB/s]
change:
       time:   [-1.1634% -0.5473% +0.0372%] (p = 0.08 > 0.05)
       thrpt:  [-0.0372% +0.5503% +1.1771%]

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) low mild

1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [311.60 ms 315.16 ms 318.75 ms]
       thrpt:  [31.372 Kelem/s 31.730 Kelem/s 32.093 Kelem/s]
change:
       time:   [-2.5761% -1.0086% +0.6139%] (p = 0.23 > 0.05)
       thrpt:  [-0.6102% +1.0189% +2.6442%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [33.737 ms 33.958 ms 34.200 ms]
       thrpt:  [29.240  elem/s 29.448  elem/s 29.641  elem/s]
change:
       time:   [-1.1951% -0.2228% +0.7203%] (p = 0.64 > 0.05)
       thrpt:  [-0.7152% +0.2233% +1.2095%]

Found 6 outliers among 100 measurements (6.00%)
4 (4.00%) high mild
2 (2.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 99.2 ± 10.0 90.3 119.8 1.00
neqo msquic reno on 212.6 ± 8.4 204.3 230.9 1.00
neqo msquic reno 215.4 ± 13.1 201.0 243.3 1.00
neqo msquic cubic on 213.9 ± 12.5 203.6 240.7 1.00
neqo msquic cubic 221.6 ± 12.0 207.5 243.9 1.00
msquic neqo reno on 97.9 ± 18.3 83.0 158.3 1.00
msquic neqo reno 97.4 ± 19.9 82.1 159.9 1.00
msquic neqo cubic on 125.3 ± 71.8 82.5 381.7 1.00
msquic neqo cubic 92.5 ± 14.7 82.2 139.6 1.00
neqo neqo reno on 158.5 ± 29.0 127.8 243.3 1.00
neqo neqo reno 156.6 ± 63.0 122.9 395.1 1.00
neqo neqo cubic on 216.1 ± 107.4 127.8 443.1 1.00
neqo neqo cubic 220.7 ± 109.7 128.2 461.6 1.00

⬇️ Download logs

@larseggert larseggert added the blocked Blocked on something else label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on something else
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant