Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle clippy::pedantic on neqo-crypto. #356

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

o0Ignition0o
Copy link
Collaborator

@o0Ignition0o o0Ignition0o commented Dec 15, 2019

Part of #150, I was struggling trying to disable the default features (which doesn't do too well with build.rs) but given the number of warnings, we might as well clear them all instead :)

I don't know enough about the internals to be 100% confident Aead::expansion() will remain static, so please let me know if I should revert the change and allow unused self instead :)

@o0Ignition0o o0Ignition0o force-pushed the crypto_clippy_pedantic branch from 7d791bf to 19bfc98 Compare December 15, 2019 10:06
@o0Ignition0o o0Ignition0o changed the title Toggle clippy::pedantic on neqo-crypto. WIP Toggle clippy::pedantic on neqo-crypto. Dec 15, 2019
@o0Ignition0o o0Ignition0o force-pushed the crypto_clippy_pedantic branch from 19bfc98 to 1708ad1 Compare December 15, 2019 10:49
@o0Ignition0o o0Ignition0o changed the title WIP Toggle clippy::pedantic on neqo-crypto. Toggle clippy::pedantic on neqo-crypto. Dec 15, 2019
@o0Ignition0o o0Ignition0o force-pushed the crypto_clippy_pedantic branch from 1708ad1 to 7ca70d5 Compare December 15, 2019 10:59
@o0Ignition0o
Copy link
Collaborator Author

cannot find function max_value in module std::u64
It seems target related, I'm going to find out which one, and fix it :)

@o0Ignition0o o0Ignition0o force-pushed the crypto_clippy_pedantic branch from 7ca70d5 to 5a2e850 Compare December 15, 2019 11:25
@o0Ignition0o o0Ignition0o changed the title Toggle clippy::pedantic on neqo-crypto. WIP Toggle clippy::pedantic on neqo-crypto. Dec 15, 2019
@o0Ignition0o o0Ignition0o force-pushed the crypto_clippy_pedantic branch from 5a2e850 to 866f8a1 Compare December 15, 2019 12:46
@o0Ignition0o o0Ignition0o changed the title WIP Toggle clippy::pedantic on neqo-crypto. Toggle clippy::pedantic on neqo-crypto. Dec 15, 2019
neqo-crypto/src/aead.rs Outdated Show resolved Hide resolved
neqo-crypto/src/time.rs Outdated Show resolved Hide resolved
@o0Ignition0o o0Ignition0o force-pushed the crypto_clippy_pedantic branch 2 times, most recently from 16e2378 to d778760 Compare December 16, 2019 08:07
@agrover agrover force-pushed the crypto_clippy_pedantic branch from d778760 to 5739ace Compare December 16, 2019 23:13
@mergify mergify bot merged commit 8842c48 into mozilla:master Dec 16, 2019
@o0Ignition0o o0Ignition0o deleted the crypto_clippy_pedantic branch December 17, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants