Large transport bufs #806
Merged
Large transport bufs #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrover
force-pushed
the
large-transport-bufs
branch
3 times, most recently
from
6fbbe53
to
07384bd
Compare
martinthomson
approved these changes
Jul 9, 2020
| @@ -1852,7 +1852,7 @@ mod tests { | |||
| if let ConnectionEvent::RecvStreamReadable { stream_id } = e { | |||
| if stream_id == request_stream_id { | |||
| // Read the DATA frame. | |||
| let mut buf = [1_u8; 0xffff]; | |||
| let mut buf = vec![1_u8; Connection::stream_recv_buffer_size()]; | |||
There was a problem hiding this comment.
Why is this an associated function and not an exported constant?
There was a problem hiding this comment.
I think exported constant is better. I'll follow up with another PR.
| @@ -280,7 +280,7 @@ pub struct TxBuffer { | |||
| } | |||
|
|
|||
| impl TxBuffer { | |||
| const BUFFER_SIZE: usize = 0xFFFF; // 64 KiB | |||
| pub const BUFFER_SIZE: usize = 0x10_0000; // 1 MiB | |||
There was a problem hiding this comment.
Do you think that it makes sense to use a single common constant for these?
There was a problem hiding this comment.
I think keeping them separate might come in handy, so let's keep them separate for now.
added 2 commits
July 9, 2020 00:46
This should help to prevent STREAM_DATA_BLOCKED messages. Fix up max_data() test that broke when const was increased. Also expose TxBuffer::BUFFER_SIZE to avoid raw numbers as much as possible.
Add static const methods to get send and receive buffer sizes. This is useful for testing in http3 crate, for example. Alter tests in http3 and transport crates to not assume a given buffer size.
agrover
force-pushed
the
large-transport-bufs
branch
from
07384bd
to
b6f89b1
Compare
agrover
pushed a commit
to agrover/neqo
that referenced
this pull request
Jul 10, 2020
Followup to mozilla#806, this is simpler than const methods on Connection. Note that while we can change these constants now, setting them to different values will cause some tests to fail. Spending time to fix tests for different const values is not justified yet.
agrover
pushed a commit
to agrover/neqo
that referenced
this pull request
Jul 10, 2020
Followup to mozilla#806, this is simpler than const methods on Connection. Note that while we can change these constants now, setting them to different values will cause some tests to fail. Spending time to fix tests for different const values is not justified yet.
agrover
pushed a commit
to agrover/neqo
that referenced
this pull request
Jul 10, 2020
Followup to mozilla#806, this is simpler than const methods on Connection. Note that while we can change these constants now, setting them to different values will cause some tests to fail. Spending time to fix tests for different const values is not justified yet.
mergify bot
pushed a commit
that referenced
this pull request
Jul 13, 2020
Followup to #806, this is simpler than const methods on Connection. Note that while we can change these constants now, setting them to different values will cause some tests to fail. Spending time to fix tests for different const values is not justified yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase transport send & recv bufs from 64K to 1M. Most of this PR is updating tests in http3 and transport to not depend on buffers being a certain size.