-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firefox-overlay: expose more for flakes overlay/users #230
Conversation
Note to self: this doesn't quite look backward compatible and/or the other invocations of |
May I suggest adding an optional This way this would be backward compatible. Also I am not sure about the added value of having Firefox nightly as a flake knowing that the update script would have to be executed twice per day in order to follow the latest version. Which defeat the point of using Nightly at all. |
872abff
to
9abf074
Compare
@colemickens This change sounds good and backward compatible as well. |
I have no more changes to make, it would be great to have this merged. Thanks for the suggestion! |
I'm trying to extend my flake to expose the other firefox versions, but they work slightly different. Due to how the verification works for actual releases, the signature check happens "later" after my impure eval has run. (versus the nightly build, where all needed checksums are determined during the impure eval and stashed). basically these two fetchurl calls: nixpkgs-mozilla/firefox-overlay.nix Lines 116 to 117 in efda5b3
cc: @cole-h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is sort of an experiment for now until I get more feedback.
This is a small tweak that allows me to consume this overlay in flake-firefox-nightly and expose a
--pure-eval
-ablefirefox-nightly
attribute for flakes users that want to pin everything and have a purely eval-able system.Fundamentally this exposes functions so that an outside caller can determine latest information and checksums and then re-instantiate that exact version purely later. (See
update.sh
in flake-firefox-nightly for more of an idea of how it works.)