Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox-overlay: expose more for flakes overlay/users #230

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

colemickens
Copy link
Collaborator

This is sort of an experiment for now until I get more feedback.

This is a small tweak that allows me to consume this overlay in flake-firefox-nightly and expose a --pure-eval-able firefox-nightly attribute for flakes users that want to pin everything and have a purely eval-able system.

Fundamentally this exposes functions so that an outside caller can determine latest information and checksums and then re-instantiate that exact version purely later. (See update.sh in flake-firefox-nightly for more of an idea of how it works.)

@colemickens
Copy link
Collaborator Author

Note to self: this doesn't quite look backward compatible and/or the other invocations of firefoxVersion need updating.

@nbp
Copy link
Collaborator

nbp commented Jul 8, 2020

May I suggest adding an optional info attribute as an optional attribute expected by versionInfo, which if set would be returned without checking, and is expected to be the content produced by versionInfo if not set.

This way this would be backward compatible.

Also I am not sure about the added value of having Firefox nightly as a flake knowing that the update script would have to be executed twice per day in order to follow the latest version. Which defeat the point of using Nightly at all.

@colemickens colemickens force-pushed the master branch 3 times, most recently from 872abff to 9abf074 Compare July 13, 2020 19:21
@nbp
Copy link
Collaborator

nbp commented Jul 15, 2020

@colemickens This change sounds good and backward compatible as well.
Do you still have modification to do, or should I proceed and merge these changes?

@colemickens
Copy link
Collaborator Author

I have no more changes to make, it would be great to have this merged. Thanks for the suggestion!

@colemickens
Copy link
Collaborator Author

I'm trying to extend my flake to expose the other firefox versions, but they work slightly different. Due to how the verification works for actual releases, the signature check happens "later" after my impure eval has run. (versus the nightly build, where all needed checksums are determined during the impure eval and stashed).

basically these two fetchurl calls:

file = builtins.fetchurl info.chksum;
asc = builtins.fetchurl info.chksumSig;

cc: @cole-h

Copy link
Collaborator

@nbp nbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nbp nbp merged commit 9f3df31 into mozilla:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants