Fix duration check #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zaach could you review this PR please? Thank you. |
| @@ -115,7 +115,7 @@ convict provides serveral predefined formats for validation that you can use ([u | |||
| * `url` | |||
| * `email` | |||
| * `ipaddress` - IPv4 and IPv6 addresses | |||
| * `duration` - miliseconds or a human readable string (e.g. "5 days") | |||
| * `duration` - miliseconds or a human readable string (e.g. "3000", "5 days") | |||
|
@pdehaan: done. Thanks. |
|
For the record, the duration check in human readable string was (unintentionally I believe) removed with commit b7ace05#diff-7763d1369911b91b757ba7ff51d734a2L37. I say unintentionally because the @zaach could you review this PR please? Thank you. |
|
Ah, good catch. 👍 |
| @@ -115,7 +115,7 @@ convict provides serveral predefined formats for validation that you can use ([u | |||
| * `url` | |||
| * `email` | |||
| * `ipaddress` - IPv4 and IPv6 addresses | |||
| * `duration` - miliseconds or a human readable string (e.g. "5 days") | |||
| * `duration` - milliseconds or a human readable string (e.g. "3000", "5 days") | |||
There was a problem hiding this comment.
Hrm, that should not be a string.
zaach
added a commit
that referenced
this pull request
Jan 15, 2015
Fix integers enclosed in quotes for #54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #53.