Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'varify' browserify transform to support IE9,10 #61

Merged
merged 1 commit into from
Feb 5, 2015
Merged

Add 'varify' browserify transform to support IE9,10 #61

merged 1 commit into from
Feb 5, 2015

Commits on Jan 20, 2015

  1. Add 'varify' browserify transform to support IE9,10

    In f4648fc I documented a way to use convict under browserify. That was fine, until trying IE<11, which currently breaks because convict uses `const`.
    
    Fortunately, browserify has [a feature for that](https://github.com/substack/node-browserify#browserifytransform), and a simple browserify transform exists for this specific const→var simplification: [varify](https://www.npmjs.com/package/varify).
    
    * The good:
        * Fixes IE9,IE10 compatibility.
        * Only impacts browserify usage (your usage of `const` out of browserify persists, and unit tests impact is null).
    * The bad:
        * But additional work on convict using other recent features unsupported by IE might re-break it...
        * ... and I don't see an easy way to unit-test this...
        * ... but we can add more transforms when that happens.
    
    Still, that improves the situation now, doesn't hurt, and is using the recommended browserify feature for this specific need, so I think it's worthwhile.
    ronjouch committed Jan 20, 2015
    Configuration menu
    Copy the full SHA
    a2c7dca View commit details
    Browse the repository at this point in the history