Don't publish recipes that require advanced capabilities to the general collection #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaredkerim @leplatrem Can you both look at this? I think it's broad enough that it would benefit from both of your reviews. I know that Mat is on PTO next week, which is fine. This can just wait a while. |
leplatrem
approved these changes
Sep 9, 2019
normandy/recipes/api/filters.py
Outdated
|
|
||
| if baseline_only: | ||
| recipes = list(qs) | ||
| assert all(isinstance(recipe, Recipe) for recipe in recipes) |
There was a problem hiding this comment.
note: assertions errors are not raised if the server runs with python -O (optimized)
There was a problem hiding this comment.
Good point. I'll change this to an exception.
|
|
||
| requests = requestsmock.request_history | ||
| for i, req in enumerate(requests): | ||
| print(i, req.method, req.url) |
| submitted = requestsmock.request_history[4].json() | ||
| requests = requestsmock.request_history | ||
| for i, req in enumerate(requests): | ||
| print(i, req.method, req.url) |
| # Approving fails. | ||
| requestsmock.request("patch", collection_url, status_code=403) | ||
| print("expecting patch to:", rs_urls["workspace"]["capabilities"]["collection"]) |
…al collection Fixes mozilla#1935
mythmon
force-pushed
the
baseline-capabilities
branch
from
88a651a
to
7ec2944
Compare
I look forward to this! You should file an issue here when that is something we can use here. bors r= @leplatrem |
bors bot
added a commit
that referenced
this pull request
Sep 18, 2019
1960: Don't publish recipes that require advanced capabilities to the general collection r=leplatrem a=mythmon This ended up being way more complicated than I thought. I'm not really happy with the amount of duplication and complexity it has introduced, but I also don't see a great way to improve it. Any ideas? Fixes #1935 Co-authored-by: Mike Cooper <mythmon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up being way more complicated than I thought. I'm not really happy with the amount of duplication and complexity it has introduced, but I also don't see a great way to improve it. Any ideas?
Fixes #1935