Switch to Poetry #2160
Merged
Switch to Poetry #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythmon
force-pushed
the
poetry
branch
2 times, most recently
from
26ed74f
to
6f608fc
Compare
|
The main thing I was hoping you would check (and I should have said this earlier, sorry) was if the new docs worked for you locally. I tested out the Docker workflow a little, and CI works. I wanted to make sure the non-Docker dev environment worked for someone else too. I'll fix the merge conflicts. |
|
ooohhh i ended up checking out the docker workflow 😅 lemme go test out non docker |
|
kk i didn't seem to have any trouble for local dev |
|
Awesome, thanks for checking! bors r= @tiftran |
bors bot
added a commit
to mozilla/ci-docker-bases
that referenced
this pull request
Apr 8, 2020
102: Add Poetry to Therapist image r=rehandalal a=mythmon This is helpful for mozilla/normandy#2160. Co-authored-by: Mike Cooper <mythmon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2159