Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JS build step and tooling #2233

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Remove JS build step and tooling #2233

merged 2 commits into from
Jun 16, 2020

Conversation

rehandalal
Copy link
Contributor

Fixes #2232

r?

@rehandalal rehandalal requested a review from mythmon June 9, 2020 00:02
mythmon
mythmon suggested changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@mythmon mythmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a readme to the client/ directory, explaining that the code there is dead and just kept as a reference? And maybe comments in the original sources to the same effect?

Besides that, this looks good to me.

@rehandalal rehandalal requested a review from mythmon June 16, 2020 21:40
mythmon
mythmon approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@mythmon mythmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

bors bot added a commit that referenced this pull request Jun 16, 2020
@bors @rehandalal
Merge #2233
b14493c 
2233: Remove JS build step and tooling r=mythmon a=rehandalal

Fixes #2232 

r?

Co-authored-by: Rehan Dalal <rehandalal@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jun 16, 2020

Build failed:

@mythmon
Copy link
Contributor

mythmon commented Jun 16, 2020

Looks like a transient network failure:

requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

bors retry

@mythmon mythmon mentioned this pull request Jun 16, 2020
Merged
@bors
Copy link
Contributor

bors bot commented Jun 16, 2020

Build succeeded:

@bors bors bot merged commit f69977c into mozilla:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythmon mythmon mythmon approved these changes

Assignees

@mythmon mythmon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove webpack build step
2 participants
@rehandalal @mythmon