Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused newrelic dependency #2293

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Remove unused newrelic dependency #2293

merged 2 commits into from
Dec 14, 2020

Conversation

mythmon
Copy link
Contributor

@mythmon mythmon commented Dec 11, 2020

Fixes #2292

@mythmon mythmon requested a review from sciurus December 11, 2020 19:20
sciurus
sciurus suggested changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@sciurus sciurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're doing this, you'll also want to

  • delete newrelic.ini
  • remove NEW_RELIC_CONFIG_FILE from the Dockerfiles

sciurus
sciurus approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@sciurus sciurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Dec 14, 2020
@bors @mythmon
Merge #2293
eacfc66 
2293: Remove unused newrelic dependency r=sciurus a=mythmon

Fixes #2292


Co-authored-by: Michael Cooper <mythmon@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 14, 2020

Build failed:

@mythmon
Copy link
Contributor Author

mythmon commented Dec 14, 2020

bors retry

@bors
Copy link
Contributor

bors bot commented Dec 14, 2020

Build succeeded:

@bors bors bot merged commit 4e73ca7 into master Dec 14, 2020
@bors bors bot deleted the remove-newrelic branch December 14, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sciurus sciurus sciurus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove newrelic dependency
2 participants
@mythmon @sciurus