Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retrospective ADR for usage of content signing #2311

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Add retrospective ADR for usage of content signing #2311

merged 2 commits into from
Mar 2, 2021

Conversation

mythmon
Copy link
Contributor

@mythmon mythmon commented Feb 19, 2021

This may help when reviewing recent problems with the signing infrastructure, and to better undrestand Normandy's history.

Fixes #2308

@mythmon
Add retrospective ADR for usage of content signing
b7e1a7f 
This may help when reviewing recent problems with the signing infrastructure, and to better undrestand Normandy's history.

Fixes #2308
rehandalal
rehandalal approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@rehandalal rehandalal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Mar 2, 2021
@bors @mythmon
Merge #2311
0df187f 
2311: Add retrospective ADR for usage of content signing r=rehandalal a=mythmon

This may help when reviewing recent problems with the signing infrastructure, and to better undrestand Normandy's history.

Fixes #2308


Co-authored-by: Michael Cooper <mythmon@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 2, 2021

Build failed:

@mythmon
Copy link
Contributor Author

mythmon commented Mar 2, 2021

bors retry

@bors
Copy link
Contributor

bors bot commented Mar 2, 2021

Build succeeded:

@bors bors bot merged commit b8bbcab into master Mar 2, 2021
@bors bors bot deleted the adr-content-signature branch March 2, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rehandalal rehandalal rehandalal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retrospective ADR for using Content Signature to sign recipes
2 participants
@mythmon @rehandalal