version 100: first pass #2332
version 100: first pass #2332
Conversation
normandy/recipes/filters.py
Outdated
| smallest_version = versions[0] | ||
| largest_version = versions[-1] | ||
|
|
||
| # check whether versions are continuous |
There was a problem hiding this comment.
One little thing: this comment talks about checking if the range is contiguous, but then the if statement and the 'then'-block are the non-contiguous case. It works fine, but I think it would read better in the other order (or if the comment was changed to talk about non-contiguous).
| [ | ||
| f'(env.version|versionCompare("{smallest_version}.!")>=0)', | ||
| f'(env.version|versionCompare("{largest_version}.*")<0)', | ||
| ] | ||
| ) | ||
|
|
||
| def get_capabilities(self): |
There was a problem hiding this comment.
This will need the capability for the versionCompare filter to be declared.
There was a problem hiding this comment.
i took a peek at VersionRange and it had jexl.context.env.version for capabilities too, I would assume, Versions would need it as well?
There was a problem hiding this comment.
Yeah, this seems right. I'm not sure why it wasn't here before.
|
@mythmon eek, I assumed that I would've missed something considering this is my first time working on filters, therefore the initial commit was a "first pass" or "first attempt". Will be adding the capabilities to the filter. |
|
bors r= @mythmon |
No description provided.