Remove check about Remote Settings group_check_enabled #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
force-pushed
the
remote-settings-remove-group-check
branch
from
e9d08df
to
b66fb22
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 19, 2022
2335: Remove check about Remote Settings group_check_enabled r=tiftran a=leplatrem From kinto-dist >= 27, we don't offer the possibility to disable the group check on a particular collection. Hence, there's no need to check it anymore (the field will always be `true`). Plus, the check in this code was wrong, it was raising `Review was not disabled ...` when the `group_check_enabled` field was `True` Co-authored-by: Mathieu Leplatre <mathieu@mozilla.com>
|
Timed out. |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From kinto-dist >= 27, we don't offer the possibility to disable the group check on a particular collection. Hence, there's no need to check it anymore (the field will always be
true).Plus, the check in this code was wrong, it was raising
Review was not disabled ...when thegroup_check_enabledfield wasTrue