Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synchronous render throw bug #1181

Merged
merged 2 commits into from
Jan 7, 2019
Merged

Conversation

fdintino
Copy link
Collaborator

@fdintino fdintino commented Jan 7, 2019

Fix bug where exceptions were silently swallowed with synchronous render

fixes #678, fixes #1116, fixes #1127, and fixes #1164. closes #689

@codecov-io
Copy link

codecov-io commented Jan 7, 2019

Codecov Report

Merging #1181 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1181      +/-   ##
==========================================
+ Coverage   89.94%   89.94%   +<.01%     
==========================================
  Files          22       22              
  Lines        2983     2985       +2     
==========================================
+ Hits         2683     2685       +2     
  Misses        300      300
Impacted Files Coverage Δ
nunjucks/src/environment.js 86.79% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 692afec...bb59ec3. Read the comment docs.

@fdintino fdintino merged commit 68ba15c into master Jan 7, 2019
@fdintino fdintino deleted the fix-synchronous-render-throw-bug branch January 7, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants