-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reject
filter
#1279
Add reject
filter
#1279
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1279 +/- ##
==========================================
- Coverage 89.60% 89.57% -0.04%
==========================================
Files 22 22
Lines 3020 3030 +10
==========================================
+ Hits 2706 2714 +8
- Misses 314 316 +2
Continue to review full report at Codecov.
|
It's better to merge it after #1278 since they almost the same. |
f25c3f4
to
31b3dcf
Compare
@fdintino now it's ready. Codecov shows uncovered lines for file that is not in my PR for some reason |
@fdintino Can you please trigger build in Travis for |
@fdintino can we finish this Pull Request? :) |
@ogonkov : absolutely! My apologies though: it may not be for a week or two, at least. Only just got back to work from paternity leave, still managing remote work with a newborn and getting through a backlog of open source project maintenance. |
f859fe3
to
1736334
Compare
Summary
Proposed change:
Add
reject
filter to match Jinja2 behaviour.Closes #282.
Checklist
I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.