Fix nunjucks for windows: relative paths and tests

[SamyPesse]

The goals of this PR are:

• Fix relative paths on Windows
• Adapt tests for windows (some tests are using \n and on windows it's \r\n)
• Maybe if you want to, adapt tests script to work with Appveyor

[SamyPesse]

The main problem with unit tests is that we are comparing strings that include \n like at https://github.com/mozilla/nunjucks/blob/master/tests/compiler.js#L326

This is failing on Windows because it's replaced by \r\n.

@jlongster Should I adapt the tests to use os.EOL or should we normalize the output or render to normalize EOLs?

Or we can just normalize tests by wrapping the render with .replace('\r\n', '\n')

[jlongster]

@SamyPesse hm that's tricky. Any chance you know what other projects do? Is it safe to normalize it?

[SamyPesse]

This is maybe safer to just normalize tests for now, for example at https://github.com/mozilla/nunjucks/blob/master/tests/compiler.js#L326:

expect(normEOL(res)).to.be('somecontenthere\n');

with:

function normEOL(s) {
    return s.replace("\r\n", "\n");
}

ok ?

[jlongster]

That works for me!

[jlongster]

I'd say we only need to do it in tests where we need to compare the \n.

[SamyPesse]

Tests are now working on Windows, I'm testing setup tests on Appveyor (for my fork).

the use of make for tests is not really usefull and I'm not usre it'll work by default on windows (make is not installed with node).
The use of make at https://github.com/mozilla/nunjucks/blob/master/package.json#L23 can be replaced by only using npm scripts. Can I include this in my PR ?

[SamyPesse]

BTW here are the builds that I'm testing using AppVeyor: https://ci.appveyor.com/project/SamyPesse/nunjucks

[SamyPesse]

There is a very important issue in Mocha for windows that has been fixed in a merged PR but not yet release to NPM: mochajs/mocha#333 (comment)

[jlongster]

What the issue we experience because of that bug? They say they won't backport to 0.10 but I still want to support that.

[SamyPesse]

Basically stdout and stderr are not flushed and so not visible in the build logs. The only other workaround is to use the --no-exit option of mocha, but in this case builds fail because of timeout (but logs are available ...).

I'm running some tests, but I fix this is not important if logs are not available for some windows builds, it's enough to know that it's failing and getting the logs for node 0.11, because if it's failing only for 0.10/0.8, it will probably fail for the same reason on travis (where the logs are always available).

Sorry if my comment is not clear enough, I'm not an english native :)

[SamyPesse]

🎉 🎈 🚀 Tests are passing on AppVeyor: https://ci.appveyor.com/project/SamyPesse/nunjucks/build/job/94ovau3gea1co8nr !

At least on 0.11, I'm still waiting for 0.8 and 0.10: https://ci.appveyor.com/project/SamyPesse/nunjucks

[SamyPesse]

@jlongster this is ready to be merged :)

I disabled windows builds for node 0.8 because it was always failing without being related to Nunjucks: https://ci.appveyor.com/project/SamyPesse/nunjucks/build/1.0.3/job/nd0nj203yqeods0c
Having tests for 0.10 and 0.11 on Windows is enough and better than nothing.

You can signup to appveyor and create a project for nunjucks if you want to enable windows testing, otherwise at least it's ready for it :)

[nijikokun]

👍

[popomore]

\n needn't be replaced, right?

[SamyPesse]

You mean using /\r\n|\r/g instead? I think it will work fine, yes.

[popomore]

Yes

[SamyPesse]

Ok I'll replace it

[popomore]

LGTM

[SamyPesse]

Thanks 👍 🍻

[jlongster]

@SamyPesse thanks for your work on it! As far as Appveyor is concerned, is your project here (https://ci.appveyor.com/project/SamyPesse/nunjucks) testing mozilla's project or your local fork? I added Mozilla's repo but its showing up under my name: https://ci.appveyor.com/project/jlongster/nunjucks

We can keep it under your name if its testing this repo. I'll add a link to the README.

[SamyPesse]

It's testing my fork, I can't enable it to test this repo (since I don't have access to the repo webhooks).

[popomore]

https://ci.appveyor.com/project/jlongster/nunjucks should work now.

@jlongster you can register a mozilla account if want the link project/mozilla/nunjucks, or rename your account.

http://help.appveyor.com/discussions/questions/744-using-appveyor-for-a-github-org

[jlongster]

Ok, thanks. I'll keep it under jlongster because I don't want to manage the mozilla account at Appveyor. As long as it's testing this repo.

[SamyPesse]

Any news on when the latest updates will be available on NPM? :)

[jlongster]

Because of some of the bugs we found I wanted to make sure there wasn't anything else outstanding with this. And I got busy recently. I will put some time into it this week though and make a release if it looks stable.

[jlongster]

@SamyPesse just pushed out v1.3.0. Thanks for all your work! Is there any chance you could add documentation for the features you added in the /docs folder? Particularly for relative templates, but also for the noCache option in FileSystemLoader.