Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump chokidar version to fix node 6.x deprecated call #789

Merged
merged 1 commit into from
Jul 11, 2016

Conversation

tbouron
Copy link
Contributor

@tbouron tbouron commented Jul 10, 2016

Root cause comes from fsevents, see PR

Before the bump

$ node --version
v6.3.0

$ node -e 'require("chokidar")'
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

[... omitted]
=====================


==== C stack trace ===============================

 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)
 2: fse::FSEvents::Initialize(v8::Local<v8::Object>)
 3: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)
 4: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>)
 6: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)
 7: 0x17987870961b
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================
[... omitted]

After, everything works fine, no more stacktrace, including for downstream projects

@carljm carljm merged commit 221fec8 into mozilla:master Jul 11, 2016
@ghost
Copy link

ghost commented Jul 22, 2016

This looks to already be on 3.x-dev (master) but would be great to be able to work with node 6.x on a stable tag, would it be appropriate for this land in a v2.4.3 as well?

BTW I tested and confirmed this fix with node 6.3.1 as well.

Would It be appropriate to create a separate issue for this concern?

@carljm
Copy link
Contributor

carljm commented Jul 22, 2016

This fix is already on the 2.x branch and will be in 2.4.3 when it happens. I don't know when that'll be; when I have time to roll a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants