Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

Release v1.0.41 #975

Closed
stenington opened this issue Dec 13, 2013 · 14 comments
Closed

Release v1.0.41 #975

stenington opened this issue Dec 13, 2013 · 14 comments

Comments

@stenington
Copy link
Contributor

https://github.com/mozilla/openbadges/releases/tag/v1.0.41

Changes

  • fixes baked badge uploading
  • fixes badge img sizing in groups in IE8

Includes PRs #967, #972, #979

@stenington
Copy link
Contributor Author

This is currently in staging: http://openbadges.mofostaging.net

@ghost ghost assigned stenington Dec 13, 2013
@stenington
Copy link
Contributor Author

Waiting in staging until we figure out this: #967 (comment)

@stenington
Copy link
Contributor Author

Fixed in #979, trying again with v1.0.41

@stenington
Copy link
Contributor Author

@cmcavoy
Copy link
Contributor

cmcavoy commented Dec 16, 2013

I downloaded a badge (by right clicking and saving as), then deleted the badge, then uploaded the badge.

Everything worked as expected.

@stenington
Copy link
Contributor Author

Cool, things look good to me too. Badge img sizes in groups is fine in IE8 as well.

@stenington
Copy link
Contributor Author

@stenington
Copy link
Contributor Author

Hmm, in prod I get could not get assertion: unreachable

@stenington stenington reopened this Dec 16, 2013
@cmcavoy
Copy link
Contributor

cmcavoy commented Dec 16, 2013

Might be a https issue...the ssl cert might not like the :80. That's just
speculation though, /cc @jdotpz

On Mon, Dec 16, 2013 at 3:51 PM, Mike Larsson notifications@git.luolix.topwrote:

The demo badge url in prod seems to be:
https://backpack.openbadges.org:80/demo/badge.json?title=DEMO%3A%20Open%20Badges%20Demo%20Badge&image=https%3A%2F%2Fbackpack.openbadges.org%3A80%2F_demo%2Fpd.large.png&recipient=sha256%24934b9bca3cf2eb01143ab59f3e85361e730cb7d0c8d45f22a1572280e28b92c3

Maybe it doesn't like the :80?


Reply to this email directly or view it on GitHubhttps://github.com//issues/975#issuecomment-30704581
.

@chmcavoy http://twitter.com/chmcavoy
http://lonelylion.com

@jdotpz
Copy link

jdotpz commented Dec 16, 2013

Yes, you are https'ing, then specifying port 80. That won't work.

----- Original Message -----
From: "Chris McAvoy" notifications@github.com
To: "mozilla/openbadges" openbadges@noreply.github.com
Cc: "JP Schneider" jp@mozillafoundation.org
Sent: Monday, December 16, 2013 3:54:54 PM
Subject: Re: [openbadges] Release v1.0.41 (#975)

Might be a https issue...the ssl cert might not like the :80. That's just
speculation though, /cc @jdotpz

On Mon, Dec 16, 2013 at 3:51 PM, Mike Larsson notifications@git.luolix.topwrote:

The demo badge url in prod seems to be:
https://backpack.openbadges.org:80/demo/badge.json?title=DEMO%3A%20Open%20Badges%20Demo%20Badge&image=https%3A%2F%2Fbackpack.openbadges.org%3A80%2F_demo%2Fpd.large.png&recipient=sha256%24934b9bca3cf2eb01143ab59f3e85361e730cb7d0c8d45f22a1572280e28b92c3

Maybe it doesn't like the :80?


Reply to this email directly or view it on GitHubhttps://github.com//issues/975#issuecomment-30704581
.

@chmcavoy http://twitter.com/chmcavoy
http://lonelylion.com


Reply to this email directly or view it on GitHub:
#975 (comment)

@stenington
Copy link
Contributor Author

@jdotpoz So both the https and port 80 are getting pulled from config. Either the config in lib/environments/ has it set, or PORT=80 is set in the environment.

@stenington
Copy link
Contributor Author

Ah, #983 should fix this.

@stenington
Copy link
Contributor Author

Closing and promoting fix in #984

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants