Merge pull request #15295 from calixteman/disable_editing

[Editing] Disable buttons until the first page is rendered
mozilla · Aug 9, 2022 · 0079ce4 · 0079ce4
2 parents 589f72e + fbce878
commit 0079ce4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/web/base_viewer.js b/web/base_viewer.js
@@ -727,12 +727,6 @@ class BaseViewer {
           if (isPureXfa) {
             console.warn("Warning: XFA-editing is not implemented.");
           } else if (isValidAnnotationEditorMode(mode)) {
-            // Ensure that the Editor buttons, in the toolbar, are updated.
-            this.eventBus.dispatch("annotationeditormodechanged", {
-              source: this,
-              mode,
-            });
-
             this.#annotationEditorUIManager = new AnnotationEditorUIManager(
               this.container,
               this.eventBus
@@ -817,6 +811,14 @@ class BaseViewer {
             this._scriptingManager.setDocument(pdfDocument); // Enable scripting.
           }
 
+          if (this.#annotationEditorUIManager) {
+            // Ensure that the Editor buttons, in the toolbar, are updated.
+            this.eventBus.dispatch("annotationeditormodechanged", {
+              source: this,
+              mode: this.#annotationEditorMode,
+            });
+          }
+
           // In addition to 'disableAutoFetch' being set, also attempt to reduce
           // resource usage when loading *very* long/large documents.
           if (

diff --git a/web/toolbar.js b/web/toolbar.js
@@ -244,7 +244,6 @@ class Toolbar {
       }
     };
     this.eventBus._on("annotationeditormodechanged", editorModeChanged);
-
     this.eventBus._on("toolbarreset", evt => {
       if (evt.source === this) {
         editorModeChanged(