Skip to content

Commit

Permalink
Merge pull request #5116 from Snuffleupagus/strict-equalities-src-core
Browse files Browse the repository at this point in the history 
Add strict equalities in src/core/* (part 1)
  • Loading branch information
@timvandermeij
timvandermeij committed Aug 1, 2014
2 parents df0b821 + 87038e4 commit 00eea3d
Show file tree
Hide file tree
Showing 6 changed files with 38 additions and 37 deletions.
2 changes: 1 addition & 1 deletion src/core/annotation.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ var WidgetAnnotation = (function WidgetAnnotationClosure() {
var j, jj;
for (j = 0, jj = kids.length; j < jj; j++) {
var kidRef = kids[j];
if (kidRef.num == ref.num && kidRef.gen == ref.gen) {
if (kidRef.num === ref.num && kidRef.gen === ref.gen) {
break;
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/core/arithmetic_decoder.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ var ArithmeticDecoder = (function ArithmeticDecoderClosure() {
byteIn: function ArithmeticDecoder_byteIn() {
var data = this.data;
var bp = this.bp;
if (data[bp] == 0xFF) {
if (data[bp] === 0xFF) {
var b1 = data[bp + 1];
if (b1 > 0x8F) {
this.clow += 0xFF00;
Expand Down
55 changes: 28 additions & 27 deletions src/core/bidi.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ var bidi = PDFJS.bidi = (function bidiClosure() {

function findUnequal(arr, start, value) {
for (var j = start, jj = arr.length; j < jj; ++j) {
if (arr[j] != value) {
if (arr[j] !== value) {
return j;
}
}
Expand Down Expand Up @@ -138,7 +138,7 @@ var bidi = PDFJS.bidi = (function bidiClosure() {
} else if (0x0700 <= charCode && charCode <= 0x08AC) {
charType = 'AL';
}
if (charType == 'R' || charType == 'AL' || charType == 'AN') {
if (charType === 'R' || charType === 'AL' || charType === 'AN') {
numBidi++;
}
types[i] = charType;
Expand All @@ -153,7 +153,7 @@ var bidi = PDFJS.bidi = (function bidiClosure() {
return createBidiText(str, isLTR);
}

if (startLevel == -1) {
if (startLevel === -1) {
if ((strLength / numBidi) < 0.3) {
isLTR = true;
startLevel = 0;
Expand Down Expand Up @@ -182,7 +182,7 @@ var bidi = PDFJS.bidi = (function bidiClosure() {
*/
var lastType = sor;
for (i = 0; i < strLength; ++i) {
if (types[i] == 'NSM') {
if (types[i] === 'NSM') {
types[i] = lastType;
} else {
lastType = types[i];
Expand All @@ -198,9 +198,9 @@ var bidi = PDFJS.bidi = (function bidiClosure() {
var t;
for (i = 0; i < strLength; ++i) {
t = types[i];
if (t == 'EN') {
types[i] = (lastType == 'AL') ? 'AN' : 'EN';
} else if (t == 'R' || t == 'L' || t == 'AL') {
if (t === 'EN') {
types[i] = (lastType === 'AL') ? 'AN' : 'EN';
} else if (t === 'R' || t === 'L' || t === 'AL') {
lastType = t;
}
}
Expand All @@ -210,7 +210,7 @@ var bidi = PDFJS.bidi = (function bidiClosure() {
*/
for (i = 0; i < strLength; ++i) {
t = types[i];
if (t == 'AL') {
if (t === 'AL') {
types[i] = 'R';
}
}
Expand All @@ -221,11 +221,12 @@ var bidi = PDFJS.bidi = (function bidiClosure() {
type changes to that type:
*/
for (i = 1; i < strLength - 1; ++i) {
if (types[i] == 'ES' && types[i - 1] == 'EN' && types[i + 1] == 'EN') {
if (types[i] === 'ES' && types[i - 1] === 'EN' && types[i + 1] === 'EN') {
types[i] = 'EN';
}
if (types[i] == 'CS' && (types[i - 1] == 'EN' || types[i - 1] == 'AN') &&
types[i + 1] == types[i - 1]) {
if (types[i] === 'CS' &&
(types[i - 1] === 'EN' || types[i - 1] === 'AN') &&
types[i + 1] === types[i - 1]) {
types[i] = types[i - 1];
}
}
Expand All @@ -235,18 +236,18 @@ var bidi = PDFJS.bidi = (function bidiClosure() {
to all European numbers:
*/
for (i = 0; i < strLength; ++i) {
if (types[i] == 'EN') {
if (types[i] === 'EN') {
// do before
var j;
for (j = i - 1; j >= 0; --j) {
if (types[j] != 'ET') {
if (types[j] !== 'ET') {
break;
}
types[j] = 'EN';
}
// do after
for (j = i + 1; j < strLength; --j) {
if (types[j] != 'ET') {
if (types[j] !== 'ET') {
break;
}
types[j] = 'EN';
Expand All @@ -259,7 +260,7 @@ var bidi = PDFJS.bidi = (function bidiClosure() {
*/
for (i = 0; i < strLength; ++i) {
t = types[i];
if (t == 'WS' || t == 'ES' || t == 'ET' || t == 'CS') {
if (t === 'WS' || t === 'ES' || t === 'ET' || t === 'CS') {
types[i] = 'ON';
}
}
Expand All @@ -272,9 +273,9 @@ var bidi = PDFJS.bidi = (function bidiClosure() {
lastType = sor;
for (i = 0; i < strLength; ++i) {
t = types[i];
if (t == 'EN') {
types[i] = ((lastType == 'L') ? 'L' : 'EN');
} else if (t == 'R' || t == 'L') {
if (t === 'EN') {
types[i] = ((lastType === 'L') ? 'L' : 'EN');
} else if (t === 'R' || t === 'L') {
lastType = t;
}
}
Expand All @@ -286,7 +287,7 @@ var bidi = PDFJS.bidi = (function bidiClosure() {
end-of-level-run (eor) are used at level run boundaries.
*/
for (i = 0; i < strLength; ++i) {
if (types[i] == 'ON') {
if (types[i] === 'ON') {
var end = findUnequal(types, i + 1, 'ON');
var before = sor;
if (i > 0) {
Expand All @@ -297,13 +298,13 @@ var bidi = PDFJS.bidi = (function bidiClosure() {
if (end + 1 < strLength) {
after = types[end + 1];
}
if (before != 'L') {
if (before !== 'L') {
before = 'R';
}
if (after != 'L') {
if (after !== 'L') {
after = 'R';
}
if (before == after) {
if (before === after) {
setValues(types, i, end, before);
}
i = end - 1; // reset to end (-1 so next iteration is ok)
Expand All @@ -314,7 +315,7 @@ var bidi = PDFJS.bidi = (function bidiClosure() {
N2. Any remaining neutrals take the embedding direction.
*/
for (i = 0; i < strLength; ++i) {
if (types[i] == 'ON') {
if (types[i] === 'ON') {
types[i] = e;
}
}
Expand All @@ -329,13 +330,13 @@ var bidi = PDFJS.bidi = (function bidiClosure() {
for (i = 0; i < strLength; ++i) {
t = types[i];
if (isEven(levels[i])) {
if (t == 'R') {
if (t === 'R') {
levels[i] += 1;
} else if (t == 'AN' || t == 'EN') {
} else if (t === 'AN' || t === 'EN') {
levels[i] += 2;
}
} else { // isOdd
if (t == 'L' || t == 'AN' || t == 'EN') {
if (t === 'L' || t === 'AN' || t === 'EN') {
levels[i] += 1;
}
}
Expand Down Expand Up @@ -414,7 +415,7 @@ var bidi = PDFJS.bidi = (function bidiClosure() {
var result = '';
for (i = 0, ii = chars.length; i < ii; ++i) {
var ch = chars[i];
if (ch != '<' && ch != '>') {
if (ch !== '<' && ch !== '>') {
result += ch;
}
}
Expand Down
12 changes: 6 additions & 6 deletions src/core/colorspace.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ var ColorSpace = (function ColorSpaceClosure() {
var count = originalWidth * originalHeight;
var rgbBuf = null;
var numComponentColors = 1 << bpc;
var needsResizing = originalHeight != height || originalWidth != width;
var needsResizing = originalHeight !== height || originalWidth !== width;
var i, ii;

if (this.isPassthrough(bpc)) {
Expand Down Expand Up @@ -277,11 +277,11 @@ var ColorSpace = (function ColorSpaceClosure() {
var stream = xref.fetchIfRef(cs[1]);
var dict = stream.dict;
numComps = dict.get('N');
if (numComps == 1) {
if (numComps === 1) {
return 'DeviceGrayCS';
} else if (numComps == 3) {
} else if (numComps === 3) {
return 'DeviceRgbCS';
} else if (numComps == 4) {
} else if (numComps === 4) {
return 'DeviceCmykCS';
}
break;
Expand Down Expand Up @@ -342,7 +342,7 @@ var ColorSpace = (function ColorSpaceClosure() {
return true;
}
for (var i = 0, ii = decode.length; i < ii; i += 2) {
if (decode[i] !== 0 || decode[i + 1] != 1) {
if (decode[i] !== 0 || decode[i + 1] !== 1) {
return false;
}
}
Expand Down Expand Up @@ -607,7 +607,7 @@ var DeviceRgbCS = (function DeviceRgbCSClosure() {
return (inputLength * (3 + alpha01) / 3) | 0;
},
isPassthrough: function DeviceRgbCS_isPassthrough(bits) {
return bits == 8;
return bits === 8;
},
fillRgb: ColorSpace.prototype.fillRgb,
isDefaultDecode: function DeviceRgbCS_isDefaultDecode(decodeMap) {
Expand Down
2 changes: 1 addition & 1 deletion src/core/core.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ var PDFDocument = (function PDFDocumentClosure() {
var str = strBuf.join('');
stream.pos = pos;
var index = backwards ? str.lastIndexOf(needle) : str.indexOf(needle);
if (index == -1) {
if (index === -1) {
return false; /* not found */
}
stream.pos += index;
Expand Down
2 changes: 1 addition & 1 deletion src/core/evaluator.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1436,7 +1436,7 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {
firstWidth = glyphWidth;
continue;
}
if (firstWidth != glyphWidth) {
if (firstWidth !== glyphWidth) {
isMonospace = false;
break;
}
Expand Down

0 comments on commit 00eea3d

Please sign in to comment.