Merge pull request #13996 from Snuffleupagus/downloadutils-link-check

Make `verifyManifestFiles` fail for non-linked test-cases with a `"link": true`-entry
mozilla · Sep 10, 2021 · 5678c75 · 5678c75
2 parents 57b8007 + d60cc72
commit 5678c75
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/test/downloadutils.js b/test/downloadutils.js
@@ -142,6 +142,15 @@ function verifyManifestFiles(manifest, callback) {
       verifyNext();
       return;
     }
+    if (item.link && !fs.existsSync(item.file + ".link")) {
+      console.error(
+        `WARNING: Unneeded \`"link": true\`-entry for the "${item.id}" test.`
+      );
+      error = true;
+      i++;
+      verifyNext();
+      return;
+    }
     calculateMD5(item.file, function (err, md5) {
       if (err) {
         console.log('WARNING: Unable to open file for reading "' + err + '".');

diff --git a/test/test_manifest.json b/test/test_manifest.json
@@ -3490,7 +3490,6 @@
       "md5": "8039aba56790d3597d2bc8c794a51301",
       "rounds": 1,
       "lastPage": 5,
-      "link": true,
       "type": "eq"
     },
     { "id": "text_clip_cff_cid",
@@ -3564,7 +3563,6 @@
       "file": "pdfs/issue925.pdf",
       "md5": "f58fe943090aff89dcc8e771bc0db4c2",
       "rounds": 1,
-      "link": true,
       "type": "eq"
     },
     {  "id": "issue9291",