Skip to content

Commit

Permalink
Merge pull request #18650 from calixteman/bug1914480
Browse files Browse the repository at this point in the history
[Editor] Add a missing parameter in the telemetry for the new alt text flow (bug 1914480)
  • Loading branch information
calixteman authored Aug 26, 2024
2 parents cd99be0 + e8763a0 commit b58c24a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/display/editor/stamp.js
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ class StampEditor extends AnnotationEditor {
) {
this._reportTelemetry({
action: "pdfjs.image.image_added",
data: { alt_text_modal: false },
data: { alt_text_modal: false, alt_text_type: "empty" },
});
try {
// The alt-text dialog isn't opened but we still want to guess the alt
Expand Down
7 changes: 5 additions & 2 deletions web/new_alt_text_manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ class NewAltTextManager {
});
this.#currentEditor._reportTelemetry({
action: "pdfjs.image.image_added",
data: { alt_text_modal: false },
data: { alt_text_modal: true, alt_text_type: "skipped" },
});
this.#finish();
}
Expand Down Expand Up @@ -464,7 +464,10 @@ class NewAltTextManager {
}
this.#currentEditor._reportTelemetry({
action: "pdfjs.image.image_added",
data: { alt_text_modal: true },
data: {
alt_text_modal: true,
alt_text_type: altText ? "present" : "empty",
},
});

this.#currentEditor._reportTelemetry({
Expand Down

0 comments on commit b58c24a

Please sign in to comment.