Merge pull request #11091 from Snuffleupagus/textLayer-expandTextDivs…

…-valid-padding [TextLayer] Only handle positive padding values in `expandTextDivs`
mozilla · Aug 23, 2019 · d1ef08e · d1ef08e
2 parents 490deb1 + 932fcac
commit d1ef08e
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/display/text_layer.js b/src/display/text_layer.js
@@ -643,21 +643,21 @@ var renderTextLayer = (function renderTextLayerClosure() {
           if (divProps.angle !== 0) {
             transform = `rotate(${divProps.angle}deg) ${transform}`;
           }
-          if (divProps.paddingLeft !== 0) {
+          if (divProps.paddingLeft > 0) {
             padding +=
               ` padding-left: ${divProps.paddingLeft / divProps.scale}px;`;
             transform +=
               ` translateX(${-divProps.paddingLeft / divProps.scale}px)`;
           }
-          if (divProps.paddingTop !== 0) {
+          if (divProps.paddingTop > 0) {
             padding += ` padding-top: ${divProps.paddingTop}px;`;
             transform += ` translateY(${-divProps.paddingTop}px)`;
           }
-          if (divProps.paddingRight !== 0) {
+          if (divProps.paddingRight > 0) {
             padding +=
               ` padding-right: ${divProps.paddingRight / divProps.scale}px;`;
           }
-          if (divProps.paddingBottom !== 0) {
+          if (divProps.paddingBottom > 0) {
             padding += ` padding-bottom: ${divProps.paddingBottom}px;`;
           }