Skip to content

Commit

Permalink
[Firefox] Generate a default-prefs file that can be used directly in …
Browse files Browse the repository at this point in the history
…mozilla-central (bug 1780609)
  • Loading branch information
Snuffleupagus committed Oct 8, 2023
1 parent d64f223 commit eb9b4a0
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 39 deletions.
18 changes: 0 additions & 18 deletions extensions/firefox/content/PdfJsDefaultPreferences.sys.mjs

This file was deleted.

41 changes: 20 additions & 21 deletions gulpfile.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ const __dirname = path.dirname(fileURLToPath(import.meta.url));
const BUILD_DIR = "build/";
const L10N_DIR = "l10n/";
const TEST_DIR = "test/";
const EXTENSION_SRC_DIR = "extensions/";

const BASELINE_DIR = BUILD_DIR + "baseline/";
const MOZCENTRAL_BASELINE_DIR = BUILD_DIR + "mozcentral.baseline/";
Expand Down Expand Up @@ -1262,25 +1261,29 @@ gulp.task(
)
);

function preprocessDefaultPreferences(content) {
function createDefaultPrefsFile() {
const fileName = "PdfJsViewerPrefs.js";
const licenseHeader = fs.readFileSync("./src/license_header.js").toString();

const MODIFICATION_WARNING =
"//\n// THIS FILE IS GENERATED AUTOMATICALLY, DO NOT EDIT MANUALLY!\n//\n";
const MODIFICATION_WARNING = `
//
// THIS FILE IS GENERATED AUTOMATICALLY, DO NOT EDIT MANUALLY!
//
`;

const bundleDefines = builder.merge(DEFINES, {
DEFAULT_PREFERENCES: getDefaultPreferences("mozcentral/"),
});
const prefs = getDefaultPreferences("mozcentral/");
const buf = [licenseHeader, MODIFICATION_WARNING];

content = preprocessPDFJSCode(
{
rootPath: __dirname,
defines: bundleDefines,
},
content
);
for (const name in prefs) {
let value = prefs[name];

return licenseHeader + "\n" + MODIFICATION_WARNING + "\n" + content + "\n";
if (typeof value === "string") {
value = `"${value}"`;
}
buf.push(`pref("pdfjs.${name}", ${value});`);
}

return createStringSource(fileName, buf.join("\n"));
}

function replaceMozcentralCSS() {
Expand Down Expand Up @@ -1308,8 +1311,7 @@ gulp.task(
MOZCENTRAL_EXTENSION_DIR = MOZCENTRAL_DIR + "browser/extensions/pdfjs/",
MOZCENTRAL_CONTENT_DIR = MOZCENTRAL_EXTENSION_DIR + "content/",
MOZCENTRAL_L10N_DIR =
MOZCENTRAL_DIR + "browser/locales/en-US/pdfviewer/",
FIREFOX_CONTENT_DIR = EXTENSION_SRC_DIR + "/firefox/content/";
MOZCENTRAL_DIR + "browser/locales/en-US/pdfviewer/";

const MOZCENTRAL_WEB_FILES = [
...COMMON_WEB_FILES,
Expand Down Expand Up @@ -1382,10 +1384,7 @@ gulp.task(
.src("l10n/en-US/*.properties")
.pipe(gulp.dest(MOZCENTRAL_L10N_DIR)),
gulp.src("LICENSE").pipe(gulp.dest(MOZCENTRAL_EXTENSION_DIR)),
gulp
.src(FIREFOX_CONTENT_DIR + "PdfJsDefaultPreferences.sys.mjs")
.pipe(transform("utf8", preprocessDefaultPreferences))
.pipe(gulp.dest(MOZCENTRAL_CONTENT_DIR)),
createDefaultPrefsFile().pipe(gulp.dest(MOZCENTRAL_CONTENT_DIR)),
]);
}
)
Expand Down

0 comments on commit eb9b4a0

Please sign in to comment.