Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt-text and delete buttons may overlap #17298

Closed
Snuffleupagus opened this issue Nov 20, 2023 · 2 comments · Fixed by #17329
Closed

Alt-text and delete buttons may overlap #17298

Snuffleupagus opened this issue Nov 20, 2023 · 2 comments · Fixed by #17329

Comments

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Nov 20, 2023

Attach (recommended) or Link to PDF file here: N/A

Configuration:

  • Web browser and its version: N/A
  • Operating system and its version: N/A
  • PDF.js version: 4.0.242 [3459615]
  • Is a browser extension: N/A

Steps to reproduce the problem:

  1. Open the demo viewer, https://mozilla.github.io/pdf.js/web/viewer.html#locale=en-US
  2. Add a StampAnnotation, e.g. firefox_logo.svg from the test-suite.
  3. Rotate the document once. Edit: It also reproduces without rotating, simply by making the Annotation small enough.

What is the expected behavior? (add screenshot)
That both the alt-text and delete buttons are visible and clickable.

What went wrong? (add screenshot)
The buttons overlap, see

overlap

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension): N/A

@Snuffleupagus Snuffleupagus changed the title Alt-text and delete buttons may overlap when the document is rotated Alt-text and delete buttons may overlap, e.g. when the document is rotated Nov 20, 2023
@Snuffleupagus Snuffleupagus changed the title Alt-text and delete buttons may overlap, e.g. when the document is rotated Alt-text and delete buttons may overlap Nov 20, 2023
Tanujch03 added a commit to Tanujch03/pdf.js that referenced this issue Nov 21, 2023
@Snuffleupagus
Copy link
Collaborator Author

@calixteman Can you please check with UX how we should handle this situation?

@calixteman
Copy link
Contributor

Yep I asked the question yesterday and they were thinking about moving the alt-text button in the new editor toolbar.
That said, it's Thanksgiving in US, so I guess we'll have nothing before next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants