Transform to resource transform when stroking pattern #6769
Comments
|
Are there testcases available that are currently broken because of this? |
|
Currently; no. But it is not hard to write one. Screenshots: PDF.js (f93a220): Reference (evince): |
|
Btw. I do not mind to fix this. But you may also label this as a good beginner bug, because a new developer can use the changes in #6684 as a lead for a fix. |
|
Thank you for the update. If you are willing to fix this, feel free to make a pull request so we can review it. |
|
I've been screwing around with this for some minutes. This is, because of the stroke width, a bit harder than expected. It will be necessary to fix the matrix transformation of the pattern itself, when dealing with pdf files like the one below. I guess you can yet remove the |
|
Done. No worries, take as much time as you need, it's already great that you are willing to look into it! You can find us on IRC if you need any help with this. |
Previously, we set the base transformation and pattern matrix directly to the main rendering ctx of the page, however doing this caused the current transform to be lost. This would cause issues with things like shear missing so the pattern was misaligned or when stroke was used the scale of the line width or dash would be wrong. Instead we should leave the current transform and use setTransfrom on the pattern so it is applied correctly. For axial and radial shadings I had to create a temporary canvas to draw the shading so I could in turn use setTransform. Fixes: mozilla#13325, mozilla#6769, mozilla#7847, mozilla#11018, mozilla#11597 The following already in the corpus are improved: issue8078-page1 issue1877-page1
Previously, we set the base transformation and pattern matrix directly to the main rendering ctx of the page, however doing this caused the current transform to be lost. This would cause issues with things like shear missing so the pattern was misaligned or when stroke was used the scale of the line width or dash would be wrong. Instead we should leave the current transform and use setTransfrom on the pattern so it is applied correctly. For axial and radial shadings I had to create a temporary canvas to draw the shading so I could in turn use setTransform. Fixes: mozilla#13325, mozilla#6769, mozilla#7847, mozilla#11018, mozilla#11597, mozilla#11473 The following already in the corpus are improved: issue8078-page1 issue1877-page1
Alternate title: Applying #6684-similar fix to stroke
#6684 makes sure the "current" transformation, at the moment of filling radial gradients is the
baseTransform(that of the rescource (page), as it says in the specs). However, this should also be fixed inCanvasGraphics_stroke.The text was updated successfully, but these errors were encountered: